Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More name swapping issues #180

Open
RocketMan opened this issue Aug 11, 2020 · 1 comment
Open

More name swapping issues #180

RocketMan opened this issue Aug 11, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@RocketMan
Copy link
Owner

The 'last, first' name swapping logic is still inappropriately mangling certain artist names. For example,

  1. In @romain2k's latest playlist, we see:

    • displayed: Boys Trinity Choir of Men and Girls (Princeton)
    • expect: Trinity Choir of Men, Boys and Girls (Princeton)
  2. There is a similar anomaly in earlier playlists:

    • displayed: Cambridge Choir of King's College
    • expect: Choir of King's College, Cambridge

Proposed solution: In both cases, there is an 'of' in the would-be surname. Perhaps such names could be excluded from mangling? Similarly, both 'surnames' are quite long (4 words each), which is not particularly customary. Perhaps surnames exceeding one or two words could be excluded as well?

References:
https://zookeeper.stanford.edu/?action=viewDate&seq=selList&playlist=40744
https://zookeeper.stanford.edu/?action=viewDate&seq=selList&playlist=40597

@RocketMan RocketMan added the bug Something isn't working label Aug 11, 2020
@romain2k
Copy link

romain2k commented Aug 11, 2020 via email

RocketMan added a commit that referenced this issue Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants