Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In releases after v0.1.0 moving search results scrolls the page as well, instead of just going to the next and previous items #12

Closed
brian6932 opened this issue Jan 25, 2022 · 2 comments · Fixed by #13

Comments

@brian6932
Copy link
Contributor

brian6932 commented Jan 25, 2022

As mentioned in #2 (comment)

Occurs both in the new releases, and when I web-ext build it from the repo.

Latest release (v0.2.2):
scrolling
v0.1.0:
scrollingOG
This also occurs in a near stock portable FF instance, so it doesn't seem to have anything to do with my browser configuration

@brian6932 brian6932 changed the title In releases after v0.1.0 moving search results scrolls the page as well instead of just going to the next and previous items In releases after v0.1.0 moving search results scrolls the page as well, instead of just going to the next and previous items Jan 25, 2022
@brian6932
Copy link
Contributor Author

I think this might be more clear:
v0.1.0:
v0 1 0 items
Latest release (v0.2.2):
v0 2 2 items

@brian6932
Copy link
Contributor Author

brian6932 commented Jun 5, 2022

After some testing I found the culprit
https://github.com/RogueArt/google-search-shortcuts/blob/main/src/navigator.js#L91
When this else is removed, it functions normally again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant