Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP-149] Fix Avatar Squish inside a flex container #213

Merged

Conversation

Jeremy-Walton
Copy link
Member

Why?

When an avatar was used inside a flex container, the width and height would get ignored and the avatar would squish

What Changed

  • Add min width and height to avatar component

Sanity Check

  • ~~[ ] Have you updated any usage of changed tokens?
  • [ ] Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • [ ] Do you need to update the package version?

Screenshots

Before:
Screenshot 2024-02-02 at 3 13 00 PM

After:
Screenshot 2024-02-02 at 3 13 19 PM

@Jeremy-Walton Jeremy-Walton added bug Something isn't working Components Changes to a component labels Feb 2, 2024
@Jeremy-Walton Jeremy-Walton added this to the v1.0.0 Release milestone Feb 2, 2024
@Jeremy-Walton Jeremy-Walton self-assigned this Feb 2, 2024
@Jeremy-Walton Jeremy-Walton force-pushed the op-149-avatars-in-a-flex-container-get-squished branch from f88edc8 to 3b4cf63 Compare February 7, 2024 20:27
@Jeremy-Walton Jeremy-Walton merged commit 21d9c28 into main Feb 7, 2024
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the op-149-avatars-in-a-flex-container-get-squished branch February 7, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Components Changes to a component
Development

Successfully merging this pull request may close these issues.

2 participants