Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Winget Upgrade does not install updates! #823

Open
sebneus opened this issue Jan 29, 2025 · 2 comments
Open

[Bug]: Winget Upgrade does not install updates! #823

sebneus opened this issue Jan 29, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@sebneus
Copy link

sebneus commented Jan 29, 2025

The problem

No updates are installed when WAU_ActivateGPOManagement is false (or not set) because WingetSourceCustom is not initialised.

QuickFix in file "C:\Program Files\Winget-AutoUpdate\Winget-Upgrade.ps1":
add Line 34:
[string]$Script:WingetSourceCustom = $DefaultWingetRepoName;

Regards
SebNeu

What version of WAU has the issue?

2.2.2-n

What version of Windows are you using (ex. Windows 11 22H2)?

Windows 11

What version of winget are you using?

v1.9.25200

Log information

Additional information

No response

@sebneus sebneus added the bug Something isn't working label Jan 29, 2025
@sebneus sebneus changed the title [Bug]: [Bug]: Winget Upgrade does not install updates! Jan 29, 2025
KnifMelti added a commit to KnifMelti/Winget-AutoUpdate that referenced this issue Jan 30, 2025
@KnifMelti
Copy link
Contributor

I undid my quick fix because I don't know nothing about @AndrewDemski-ad-gmail-com intentions and thoughts with this in the now closed Pull #789

@AndrewDemski-ad-gmail-com
Copy link
Contributor

HI @sebneus
Big thanks for spotting!
I must have merged those two ifs together and did not realize the obvious lack of init for that new variable.

I proposed the addition in #827

At some point we will need to pass everything through Formatter in PSScriptAnalyzer to make it easier to spot missing 'else's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants