Skip to content

Commit 2b340dc

Browse files
committed
fix: remarks from reviewer
1 parent 6fca370 commit 2b340dc

File tree

3 files changed

+22
-16
lines changed

3 files changed

+22
-16
lines changed

tests/InitCommandTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,8 @@ public function testRunWithAdminAndDefaultReadmeCreation()
210210
'\Winter\LaravelConfigWriter',
211211
$this->changeEnvFileCall('.env.example', 'env.example.yml', 'env.example_app_name_not_pascal_case.yml'),
212212
$this->changeEnvFileCall('.env.development', 'env.development.yml', 'env.development_app_name_not_pascal_case.yml'),
213-
$this->changeEnvFileCall('.env.development', 'env.development.yml', 'env.development_clerk_credentials_added.yml'),
214-
$this->changeEnvFileCall('.env.example', 'env.example.yml', 'env.example_clerk_credentials_added.yml'),
213+
$this->changeEnvFileCall('.env.development', 'env.development_app_name_not_pascal_case.yml', 'env.development_clerk_credentials_added.yml'),
214+
$this->changeEnvFileCall('.env.example', 'env.example_app_name_not_pascal_case.yml', 'env.example_clerk_credentials_added.yml'),
215215
$this->callFilePutContent(base_path('config/telescope.php'), $this->getFixture('telescope_config_after_initialization.php')),
216216
$this->callFilePutContent(base_path('config/auto-doc.php'), $this->getFixture('auto_doc_after_changes.php')),
217217
);
@@ -698,8 +698,8 @@ public function testRunWithClerkMobileAppWithPintInstalled(): void
698698
'\Winter\LaravelConfigWriter',
699699
$this->changeEnvFileCall('.env.example', 'env.example.yml', 'env.example_app_name_not_pascal_case.yml'),
700700
$this->changeEnvFileCall('.env.development', 'env.development.yml', 'env.development_app_name_not_pascal_case.yml'),
701-
$this->changeEnvFileCall('.env.development', 'env.development.yml', 'env.development_clerk_credentials_added_mobile_app.yml'),
702-
$this->changeEnvFileCall('.env.example', 'env.example.yml', 'env.example_clerk_credentials_added_mobile_app.yml'),
701+
$this->changeEnvFileCall('.env.development', 'env.development_app_name_not_pascal_case.yml', 'env.development_clerk_credentials_added_mobile_app.yml'),
702+
$this->changeEnvFileCall('.env.example', 'env.example_app_name_not_pascal_case.yml', 'env.example_clerk_credentials_added_mobile_app.yml'),
703703
$this->callFilePutContent(base_path('config/telescope.php'), $this->getFixture('telescope_config_after_initialization.php')),
704704
$this->callFilePutContent(base_path('config/auto-doc.php'), $this->getFixture('auto_doc_after_changes.php')),
705705
);

tests/fixtures/InitCommandTest/env.development_clerk_credentials_added.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ APP_DEBUG=true
55
APP_LOG_LEVEL=debug
66
APP_URL=https://mysite.com
77

8-
DB_CONNECTION=mysql
9-
DB_HOST=127.0.0.1
10-
DB_PORT=3306
11-
DB_DATABASE=my_database
12-
DB_USERNAME=my_user
13-
DB_PASSWORD=my_secret_password
8+
DB_CONNECTION=pgsql
9+
DB_HOST=
10+
DB_PORT=
11+
DB_DATABASE=
12+
DB_USERNAME=
13+
DB_PASSWORD=
1414

1515
BROADCAST_DRIVER=log
1616
CACHE_DRIVER=file
@@ -38,6 +38,9 @@ FRONTEND_URL=
3838

3939
JWT_SHOW_BLACKLIST_EXCEPTION=true
4040

41+
APP_MAINTENANCE_DRIVER="cache"
42+
CACHE_STORE="redis"
43+
4144
AUTH_GUARD="clerk"
4245
CLERK_ALLOWED_ISSUER=""
4346
CLERK_SECRET_KEY=""

tests/fixtures/InitCommandTest/env.development_clerk_credentials_added_mobile_app.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ APP_DEBUG=true
55
APP_LOG_LEVEL=debug
66
APP_URL=https://mysite.com
77

8-
DB_CONNECTION=mysql
9-
DB_HOST=127.0.0.1
10-
DB_PORT=3306
11-
DB_DATABASE=my_database
12-
DB_USERNAME=my_user
13-
DB_PASSWORD=my_secret_password
8+
DB_CONNECTION=pgsql
9+
DB_HOST=
10+
DB_PORT=
11+
DB_DATABASE=
12+
DB_USERNAME=
13+
DB_PASSWORD=
1414

1515
BROADCAST_DRIVER=log
1616
CACHE_DRIVER=file
@@ -38,6 +38,9 @@ FRONTEND_URL=
3838

3939
JWT_SHOW_BLACKLIST_EXCEPTION=true
4040

41+
APP_MAINTENANCE_DRIVER="cache"
42+
CACHE_STORE="redis"
43+
4144
AUTH_GUARD="clerk"
4245
CLERK_ALLOWED_ISSUER=""
4346
CLERK_SECRET_KEY=""

0 commit comments

Comments
 (0)