You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
examples/examples_struct/make_bindings_via_bash.sh, among other scripts, contains a hard coded path $PWD/../../build/llvm-4.0.0/build_4.0.0*/bin/binder. This looks pretty outdated, and for sure is a maintenance burden.
Decouple installation and use. Request that the executable binder be in PATH before the examples can be run. Replace the hard-coded path to the binder exutable by plain binder, nothing more.
The text was updated successfully, but these errors were encountered:
jwuttke
changed the title
Binder/Examples contain hard-coded paths to outdated llvm versions
Binder/Examples contain hard-coded paths including outdated llvm version
Mar 11, 2022
Sounds like a good idea to me, tagging @danpf who is author of this example.
@jwuttke right now we treat these examples more like "doc" then a code (ie we do not re-run them etc). But converting this to some sort of integration test (and possibly run them as part of CI) sounds great to me. PR to do so will certainly be welcome :)
examples/examples_struct/make_bindings_via_bash.sh
, among other scripts, contains a hard coded path$PWD/../../build/llvm-4.0.0/build_4.0.0*/bin/binder
. This looks pretty outdated, and for sure is a maintenance burden.Decouple installation and use. Request that the executable
binder
be inPATH
before the examples can be run. Replace the hard-coded path to the binder exutable by plainbinder
, nothing more.The text was updated successfully, but these errors were encountered: