Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder/Examples contain hard-coded paths including outdated llvm version #179

Open
jwuttke opened this issue Mar 11, 2022 · 2 comments
Open

Comments

@jwuttke
Copy link
Contributor

jwuttke commented Mar 11, 2022

examples/examples_struct/make_bindings_via_bash.sh, among other scripts, contains a hard coded path $PWD/../../build/llvm-4.0.0/build_4.0.0*/bin/binder. This looks pretty outdated, and for sure is a maintenance burden.

Decouple installation and use. Request that the executable binder be in PATH before the examples can be run. Replace the hard-coded path to the binder exutable by plain binder, nothing more.

@jwuttke jwuttke changed the title Binder/Examples contain hard-coded paths to outdated llvm versions Binder/Examples contain hard-coded paths including outdated llvm version Mar 11, 2022
@lyskov
Copy link
Member

lyskov commented Mar 14, 2022

Sounds like a good idea to me, tagging @danpf who is author of this example.

@jwuttke right now we treat these examples more like "doc" then a code (ie we do not re-run them etc). But converting this to some sort of integration test (and possibly run them as part of CI) sounds great to me. PR to do so will certainly be welcome :)

@shakfu
Copy link

shakfu commented Jul 3, 2022

If anyone is interested I have a very simple working example here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants