Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Brienne is listed as dead #421

Open
kajo404 opened this issue Apr 13, 2016 · 15 comments
Open

Brienne is listed as dead #421

kajo404 opened this issue Apr 13, 2016 · 15 comments
Labels
Milestone

Comments

@kajo404
Copy link
Collaborator

kajo404 commented Apr 13, 2016

but she has no date of death

@yashha
Copy link
Collaborator

yashha commented Apr 13, 2016

Its because we don't get any plods for her:
https://api.got.show/api/plod/bySlug/Brienne_of_Tarth

@goldbergtatyana
Copy link
Collaborator

Yeah, strangely, she is not in the list of characters with a predicted PLOD. Group 6, @ThuyNganTran @subburamr @asesselmann, any idea why there is no prediction for her? Thanks!

@jorjo1 jorjo1 added the bug label Apr 13, 2016
@mammuth mammuth modified the milestones: Website Release v1.0, v1.1 Apr 13, 2016
@sacdallago
Copy link
Contributor

@goldbergtatyana isn't it better if they show nothing in case of no PLOD for that char? For dead chars, we have 100% PLOD, right? So no PLOD is different from dead

@goldbergtatyana
Copy link
Collaborator

This would make a lot of sense, yes! very good idea @sacdallago

In the last group email Guy wrote that we processed 2028 characters, while Group 6 provided predictions for 1946 characters.

This makes a difference of 82 characters for whom we don't have a PLOD, so yeah it would be great if we could catch them and say "sorry no likelihood of death available" or so.

@mammuth @yashha @jorjo1 could we have this feature?

@subburamr
Copy link
Collaborator

Yes, I noticed that Brienne of Tarth is not in the 1946 characters. So no plod data is present. We will check and update why there is a difference.

@goldbergtatyana
Copy link
Collaborator

Thanks @subburamr for the super quick reply! We realized that we are missing PLODs for 82 characters. Could you please then look into those as well, why they escaped being trained with our ML algorithm? :)

@subburamr
Copy link
Collaborator

We seem to have missed these characters somewhere in the data processing, will update once we find the cause.

Here is the list of 82 characters which were not included in the training.
82_chars_missing_plods.txt

Comparison with the 2028 characters from api.
character_differences.txt

@goldbergtatyana
Copy link
Collaborator

Yeay, great we have the list @subburamr !

Do you also have the 26 features for them? If so, please run your machine learning algorithm in the exact same way with the exact same parameters on the full data set now (1946 + 82 characters) and report the performance here please.

👍 👍

@subburamr
Copy link
Collaborator

It appears that project A added the 82 characters after Mar 25th(our deadline) 😄
Rostlab/JS16_ProjectA#105

I will rerun the algorithm with the extra characters and upload the performance.

@gyachdav
Copy link
Collaborator

make sure that the prediction you already made do not change 😆

@mammuth
Copy link
Collaborator

mammuth commented Apr 17, 2016

What's the status here?
@subburamr

@subburamr
Copy link
Collaborator

I added the results here

@mammuth
Copy link
Collaborator

mammuth commented Apr 17, 2016

Cool!

I'm not aware of the workflow how this is going to be inserted into the A-Database, could someone bring light into this or make this going happen? @sacdallago

As far as I understood, this is going to resolve this issue, right?

@sacdallago
Copy link
Contributor

I am, yes

@marcusnovotny
Copy link
Collaborator

@sacdallago This keeps coming up on reddit and twitter. Fix needed 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

9 participants