Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

great library; using it for voltage calibration in voltmeter #4

Open
sercona opened this issue Mar 28, 2022 · 2 comments
Open

great library; using it for voltage calibration in voltmeter #4

sercona opened this issue Mar 28, 2022 · 2 comments

Comments

@sercona
Copy link

sercona commented Mar 28, 2022

wanted to give a big thanks for putting together this library!

I included it in my esp8266 voltmeter (data logger) project and it improved the accuracy with very little extra effort on my part, just had to learn how to call your api - and that was pretty easy.

tiny suggestion: for things that are positive integers (like number of points), maybe make that more explicit that its unsigned int rather than it.

it would also be interesting to know what the memory needs/usage is, as you choose the number of points and order of the poly.

again, thanks for such a great contribution.

@Rotario
Copy link
Owner

Rotario commented Mar 28, 2022

Hey, glad you're finding it useful! I've not touched this in a long time.
Right now the memory allocated is static, IIRC to make sure it doesn't crash, as the memory usage can be huge for larger orders (i think it's n^3 ish)
But I do have some dynamic matrix code from a while back so could make memory not static. right now it relies on the MAX ORDER #define somewhere.
I think the "x" value can be negative, where the x values are the LHS of the y axis.

Glad you're enjoying it!

@Rotario
Copy link
Owner

Rotario commented Mar 28, 2022

My bad - looking at the source it's all allocated on the stack - so there's no theoretical max order, just the size of your stack.
It could do with some cleaning up but if it works, it works!

Have you written a post about using it to calibrate your voltmeter? If so I could link to it on my blog https://workyourtech.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants