Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Crying Obsidian portals dont work with BetterNether #11

Open
nco2k opened this issue Apr 15, 2024 · 2 comments
Open

[Compatibility] Crying Obsidian portals dont work with BetterNether #11

nco2k opened this issue Apr 15, 2024 · 2 comments

Comments

@nco2k
Copy link

nco2k commented Apr 15, 2024

if you have BetterNether installed, then you cant create portals anymore that use Crying Obsidian. any chance to fix that?

@SplendidAlakey
Copy link

BetterNether has its own way of handling custom blocks for portals by utilizing tags: https://github.com/quiqueck/BetterNether/blob/1.20.3/src/main/generated/data/c/tags/blocks/nether_pframe.json

@Roundaround
Copy link
Owner

That's correct. In this case, they bypass the vanilla logic completely (whereas I sort of splice into it) so they by extension bypass my change as well. The best we could do would be to add crying obsidian to their new nether_pframe tag so that it gets picked up by BetterNether automatically.

You could do this today yourself with a datapack actually. https://minecraft.fandom.com/wiki/Tutorials/Creating_a_data_pack#Tags

I'm in the process of updating all my mods to 1.20.5/6 and then subsequently to 1.21, doing some long overdue feature work, bugfixes, and in some cases rewrites along the way. It's entirely possible I might just add this in there while I'm at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants