feat(Toggle): WIP #3860
Open
feat(Toggle): WIP #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-navy-digital-mod-uk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m7kvqbe1
requested changes
Aug 16, 2024
There was a problem hiding this comment.
This is a great start! A few important things we need to consider:
- Usage within forms and integration with different supported form libraries.
- Understanding the difference between controlled and uncontrolled and supporting them.
- It might be worth using an
input type="checkbox"(rememberdefaultChecked). - Make sure the component supports a
forwardedRef. - Check it plays nice with the
Fieldwrapper component. - Update form usage examples and Playwright tests.
- Make sure the appropriate ARIA and other a11y attributes are applied to the control.
- The user should be able to manipulate the component solely by using the keyboard.
- Styled focus state is missing.
- The component should support an error state.
- Red outline (see other form controls).
Very happy for you to continue rolling your own implementation as a learning exercise, but we need to make sure to address all of the stuff above. There is quite a lot to consider, which is why I suggested styling a hardened headless implementation like the Radix one:
https://github.com/radix-ui/primitives/blob/main/packages/react/switch/src/Switch.tsx
will-lamb
force-pushed
the
feature/build-toggle-component
branch
2 times, most recently
from
e6ba17f
to
b4badca
Compare
feat(Toggle): Created Toggle component feat(Toggle): Created Toggle component feat(Toggle): Working on spacing issues feat(Toggle): Working on spacing issues feat(Toggle): Spacing feat(Toggle): Added Aria labels feat(Toggle): Added test file feat(Toggle): Added toggle to formik story feat(Toggle): Centering Icons in Knobs feat(Toggle): Scaled toggle to be bigger feat(Toggle): Added keyboard handling feat(Toggle): Updated test file feat(Toggle): Updated toggle component feat(Toggle): updated toggle test file feat(Toggle): Updated form tests feat(Toggle): Fixed cursor issues with disabled component feat(Toggle): Updated form tests
will-lamb
force-pushed
the
feature/build-toggle-component
branch
from
eeddec5
to
a7bfc30
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #3859
Overview
Created a Toggle component
Reason
To add a Toggle component to the design system
Work carried out
Example.
Screenshot
Screen.Recording.2024-08-15.at.18.03.38.mov
Developer notes
At the next major release, we should change the name of this component to Switch and change the current Switch component to ToggleGroup / Toggle