Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-2583] Pipe K8s logs back into the Aqueduct executor #1238

Open
kenxu95 opened this issue Apr 24, 2023 · 6 comments
Open

[ENG-2583] Pipe K8s logs back into the Aqueduct executor #1238

kenxu95 opened this issue Apr 24, 2023 · 6 comments
Labels
Compute Integrations 💻 Created by Linear-GitHub Sync On-Call ☎️ Created by Linear-GitHub Sync

Comments

@kenxu95
Copy link
Contributor

kenxu95 commented Apr 24, 2023

This will make it a lot easier to debug K8s issues, especially on github actions where we have access to the executor logs, but the cluster has been torn down.

We can probably use the golang K8s API. Retrieve the log on operator termination and log to the appropriate surface (server logs for preview, workflow log file for published flows).

From SyncLinear.com | ENG-2583

@kenxu95 kenxu95 added Compute Integrations 💻 Created by Linear-GitHub Sync On-Call ☎️ Created by Linear-GitHub Sync labels Apr 24, 2023
@kenxu95
Copy link
Contributor Author

kenxu95 commented Apr 24, 2023

I just changed it. In talking with Kenny, 2661 was prioritized over this. I should have moved this out of 2.9 release on Friday.

@kenxu95
Copy link
Contributor Author

kenxu95 commented Apr 24, 2023

our comments crossed mid-air :-)

seems like you added a release label from the past (Jan) mistakenly (the date in paranthesis should be helpful).

@kenxu95
Copy link
Contributor Author

kenxu95 commented Apr 24, 2023

Bit confused then as to why this task you have not started on is tagged for 2.9 release (cut-off today) and the task you are working ENG-2661 on is tagged for 2.10 release (one week later)?

@kenxu95
Copy link
Contributor Author

kenxu95 commented Apr 24, 2023

No Suresh, I haven't started on this yet. I changed the ENG-2661 to progress.

@kenxu95
Copy link
Contributor Author

kenxu95 commented Apr 24, 2023

@jpurusho65 are you currently working on this?

FYI: the process is to update status to "In Progress" once you start working on a task.

@kenxu95
Copy link
Contributor Author

kenxu95 commented Apr 24, 2023

Will assign to Jerome. Taking it for now to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute Integrations 💻 Created by Linear-GitHub Sync On-Call ☎️ Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant