Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Rust-GCC/gccrs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a146b89263a62bf2ba82323977a8d6308df1bc7e
Choose a base ref
..
head repository: Rust-GCC/gccrs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bf08887a53e4801ee4a0c2f5fd64536157a2bbf5
Choose a head ref
Showing with 10 additions and 20 deletions.
  1. +0 −8 .github/bors.toml
  2. 0 .github/{bors_log_expected_warnings → log_expected_warnings}
  3. +7 −8 .github/workflows/ccpp.yml
  4. +1 −1 .github/workflows/ccpp32alpine.yml
  5. +1 −1 CONTRIBUTING.md
  6. +1 −2 README.md
8 changes: 0 additions & 8 deletions .github/bors.toml

This file was deleted.

File renamed without changes.
15 changes: 7 additions & 8 deletions .github/workflows/ccpp.yml
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ jobs:
build-and-check-ubuntu-64bit:

env:
# Force locale, in particular for reproducible results re '.github/bors_log_expected_warnings' (see below).
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
LC_ALL: C.UTF-8

runs-on: ubuntu-22.04
@@ -68,7 +68,7 @@ jobs:
run: |
cd gccrs-build
< log grep 'warning: ' | sort > log_warnings
if diff -U0 ../.github/bors_log_expected_warnings log_warnings; then
if diff -U0 ../.github/log_expected_warnings log_warnings; then
:
else
echo 'See <https://github.com/Rust-GCC/gccrs/pull/1026>.'
@@ -100,7 +100,7 @@ jobs:
build-and-check-ubuntu-64bit-glibcxx:

env:
# Force locale, in particular for reproducible results re '.github/bors_log_expected_warnings' (see below).
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
LC_ALL: C.UTF-8

runs-on: ubuntu-22.04
@@ -185,7 +185,7 @@ jobs:
build-and-check-ubuntu-32bit:

env:
# Force locale, in particular for reproducible results re '.github/bors_log_expected_warnings' (see below).
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
LC_ALL: C.UTF-8

runs-on: ubuntu-22.04
@@ -237,7 +237,7 @@ jobs:
run: |
cd gccrs-build
< log grep 'warning: ' | sort > log_warnings
if diff -U0 ../.github/bors_log_expected_warnings log_warnings; then
if diff -U0 ../.github/log_expected_warnings log_warnings; then
:
else
echo 'See <https://github.com/Rust-GCC/gccrs/pull/1026>.'
@@ -266,7 +266,6 @@ jobs:
exit 0; \
fi
# This job name must be kept in sync with .github/bors.toml.
build-and-check-gcc-5:

runs-on: ubuntu-22.04
@@ -406,7 +405,7 @@ jobs:
build-and-check-asan:

env:
# Force locale, in particular for reproducible results re '.github/bors_log_expected_warnings' (see below).
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
LC_ALL: C.UTF-8

runs-on: ubuntu-22.04
@@ -460,7 +459,7 @@ jobs:
# run: |
# cd gccrs-build
# < log grep 'warning: ' | sort > log_warnings
# if diff -U0 ../.github/bors_log_expected_warnings log_warnings; then
# if diff -U0 ../.github/log_expected_warnings log_warnings; then
# :
# else
# echo 'See <https://github.com/Rust-GCC/gccrs/pull/1026>.'
2 changes: 1 addition & 1 deletion .github/workflows/ccpp32alpine.yml
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ jobs:
build-alpine-32bit-and-check-alpine-32bit:

env:
# Force locale, in particular for reproducible results re '.github/bors_log_expected_warnings' (see below).
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
LC_ALL: C.UTF-8

runs-on: ubuntu-22.04
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ and the link to the GitHub PR sent to the submitter.
* The PR policy: Everything has to go through a PR
- An exception to this rule will be the merge commits of updating the repo against upstream GCC

* Reviewers/Maintainers of the project (aka people who have bors rights) should be pinged for reviews/questions.
* Reviewers/Maintainers of the project should be pinged for reviews/questions.

* A PR can have one or several commits (split should have a technical/logical reason, ie. no fixup-ish commit)

3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -3,7 +3,6 @@
[![Build Docker image](https://github.com/Rust-GCC/gccrs/actions/workflows/docker.yml/badge.svg)](https://github.com/Rust-GCC/gccrs/actions/workflows/docker.yml)
![Docker Pulls](https://img.shields.io/docker/pulls/philberty/gccrs)
[![project chat](https://img.shields.io/badge/zulip-join_chat-brightgreen.svg)](https://gcc-rust.zulipchat.com/)
[![Bors enabled](https://bors.tech/images/badge_small.svg)](https://app.bors.tech/repositories/32890)
[![justforfunnoreally.dev badge](https://img.shields.io/badge/justforfunnoreally-dev-9ff)](https://justforfunnoreally.dev)
# GCC Rust
![GCC Rust](logo.png?raw=true "GCC rust Logo")
@@ -255,7 +254,7 @@ With that, we're missing out on the aspect that _enforces that GCC compiles with
To encounter that, the default CI has a [_check for new warnings_ step](https://github.com/Rust-GCC/gccrs/pull/1026)
that verifies in the CI `--disable-bootstrap` build configuration that no new warnings are introduced.
If that step fails, it usually points out a new _warning_ you've introduced erroneously, and should address.
Occasionally it means that simply the `.github/bors_log_expected_warnings` file needs to be updated,
Occasionally it means that simply the `.github/log_expected_warnings` file needs to be updated,
for example if due to any kind of "environmental changes" (for example, CI "initial" compiler changes).
Unless diligently reproducing the CI configuration (in particular "initial" compiler, GCC version),
it's not really feasible to reproduce this check locally.