Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide output for all our process::Command calls #40

Open
tombh opened this issue Jan 22, 2025 · 1 comment
Open

Provide output for all our process::Command calls #40

tombh opened this issue Jan 22, 2025 · 1 comment

Comments

@tombh
Copy link
Contributor

tombh commented Jan 22, 2025

It would be good to capture STDERR like this String::from_utf8_lossy(&output.stderr) for all shell calls, so we can provide it to the user in the event of a failure. Currently, without this extra information, there's no way to debug the various cargo commands that are called before the actual shader build.

An example of the current problem is that I compiled a shader on a new user account that didn't have the correct Rust toolchain for the shader's workspace. That meant that the call to cargo tree (to query the spirv-std version) failed. But it didn't provide the error, so I had to manually run cargo tree to see what was going.

@schell
Copy link
Collaborator

schell commented Jan 27, 2025

I think we could probably write an extension to Command that does this for us and then use that at all the callsites?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants