Skip to content

ci: simplify clippy #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

ci: simplify clippy #331

merged 2 commits into from
Jul 17, 2025
+13 −57

Conversation

Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Jul 11, 2025 •
edited
Loading

Requires Rust-GPU/spirv-tools-rs#16 and publishing spirv-tools 0.12.1

Hmpf, unfortunate that we can't pass the features somehow, to a single cargo clippy --workspace invocation.

Alternatively, it might be nice to not have SPIRV-Tools' C++ code be compiled by spirv-tools-rs when built for cargo check/cargo clippy, but I don't recall if that's even feasible to do.

#329 (review)

Well, now we can :D

This also speeds up our lint CI from 7m to 6m, likely from better multi-core utilization due to checking more crates in parallel

@Firestar99 Firestar99 marked this pull request as ready for review July 17, 2025 16:47
@Firestar99 Firestar99 enabled auto-merge July 17, 2025 16:47
@Firestar99
Copy link
Member Author

This is now ready to merge!

LegNeato
LegNeato approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Firestar99 Firestar99 added this pull request to the merge queue Jul 17, 2025
Merged via the queue into main with commit 20052f8 Jul 17, 2025
13 checks passed
@Firestar99 Firestar99 deleted the skip-clippy branch July 17, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegNeato LegNeato LegNeato approved these changes

@eddyb eddyb Awaiting requested review from eddyb eddyb is a code owner

@schell schell Awaiting requested review from schell schell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firestar99 @LegNeato