Rename Sink::empty #562
Labels
Comments
dvdsk
added
breaking
|
same is true for SpatialSink::empty |
dvdsk
added a commit
that referenced
this issue
Mar 26, 2024
Made an issue for missing `is_empty()`, see: #562 The DecoderImpl enum triggerd large_enum_variant. There is not an easy fix for that. We could box the VorbisDecoder but at 572 bytes I really do not think thats worth it. Annotated it with an allow
|
Any improvements on this? |
|
not really, I am saving up some breaking changes for a big release. I rather not break ppls code multiple times. So it seems logical to save it up and provide a porting guide. |
|
though it might make sense to start collecting the changes on a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It should probably be called
is_empty. Clippy even flags on it.Changing it would break a lot of code though...
Could deprecate it first?
Let me hear you thoughts, for now I am letting clippy now to ignore it.
The text was updated successfully, but these errors were encountered: