Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove Mp4Type #612

Open
dvdsk opened this issue Sep 16, 2024 · 0 comments
Open

Refactor: Remove Mp4Type #612

dvdsk opened this issue Sep 16, 2024 · 0 comments
Labels
breaking Proposed change that would break the public API

Comments

@dvdsk
Copy link
Collaborator

dvdsk commented Sep 16, 2024

Mp4 extensions do not have any real value: https://en.wikipedia.org/wiki/MP4_file_format#Filename_extensions

Therefore the mp4 constructor can just pass mp4.

pub fn new_mp4(data: R, hint: Mp4Type) -> Result<Decoder<R>, DecoderError> {

This makes the function more in line with the rest (no need for a hint) and removes confusion from users.

@dvdsk dvdsk added the breaking Proposed change that would break the public API label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Proposed change that would break the public API
Projects
None yet
Development

No branches or pull requests

1 participant