Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BLTFilter to Filter. #618

Open
dvdsk opened this issue Sep 16, 2024 · 0 comments
Open

Rename BLTFilter to Filter. #618

dvdsk opened this issue Sep 16, 2024 · 0 comments
Labels
breaking Proposed change that would break the public API

Comments

@dvdsk
Copy link
Collaborator

dvdsk commented Sep 16, 2024

pub struct BltFilter<I> {

The filter method Billinear transform, is an implementation detail that should not appear in the API, since that limits future change. That alone is not a reason to rename it.

The current name is confusing to new novice users however and if we do a breaking release with porting/update guide that is a good moment to fix this.

Should not impact many users as most will not have specified the complete type of their source.

Still this is very much still open to discussion.

@dvdsk dvdsk added the breaking Proposed change that would break the public API label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Proposed change that would break the public API
Projects
None yet
Development

No branches or pull requests

1 participant