fix drop #198
Merged
fix drop #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmedrano
reviewed
Jul 23, 2024
src/client/client_impl.rs
Outdated
| @@ -659,6 +659,7 @@ impl Client { | |||
| impl Drop for Client { | |||
| fn drop(&mut self) { | |||
| let _m = CREATE_OR_DESTROY_CLIENT_MUTEX.lock().unwrap(); | |||
| println!("drop client is called"); | |||
|
genrally lgtm and is generally safer. Can you increment the version number to |
|
Are you interested in a pr that fixes the linting problems? |
|
If you want to follow up with lint changes go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the context of a program i wrote I run into a problem with a segfault on close. because of what happen in drop.
Here is a draft of a change that solved it for me.