Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sha2: aarch64 acceleration broken on master #568

Closed
enkore opened this issue Mar 12, 2024 · 0 comments · Fixed by #569
Closed

sha2: aarch64 acceleration broken on master #568

enkore opened this issue Mar 12, 2024 · 0 comments · Fixed by #569

Comments

@enkore
Copy link
Contributor

enkore commented Mar 12, 2024

#542 removed the sha2-asm and asm feature, which incidentally also made the aarch64 code dead, because it is behind a #[cfg(all(feature = "asm", target_arch = "aarch64"))] (

} else if #[cfg(all(feature = "asm", target_arch = "aarch64"))] {
) — since that feature is no longer declared in Cargo.toml, it cannot be enabled.

I suspect this isn't intentional, because the looongarch implementation also uses inline assembly but isn't disabled.

tarcieri pushed a commit that referenced this issue Mar 12, 2024
Fixes #568

Co-authored-by: marx <marx@fedora>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant