Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 15 Nimble & Foundation naming conflict #69

Closed
N1nomiya opened this issue Sep 21, 2023 · 13 comments
Closed

Xcode 15 Nimble & Foundation naming conflict #69

N1nomiya opened this issue Sep 21, 2023 · 13 comments

Comments

@N1nomiya
Copy link
Member

Hi, when using Xcode 15, RxNimble has an error 'Predicate' is ambiguous for type lookup in this context since Foundation has a conflict type Predicate with Nimble.
This is the related issue link in Nimble. I think maybe you want to consider the workaround described in it.

@younata
Copy link

younata commented Sep 26, 2023

Hi! As the maintainer of Nimble, I want to jump in and note that as part of addressing this name conflict, I'm planning to rename the Predicate API to Matcher. Quick/Nimble#1090 has more details about that.

@dzolnai
Copy link

dzolnai commented Oct 10, 2023

Hello, assuming you are releasing Nimble today (according to Quick/Nimble#1061 (comment)), could you make a new version of this library as well?
Thanks for the library in any case! 🙌

@ashfurrow
Copy link
Member

@dzolnai we're just looking for an update to this library that points to the new Nimble version, yeah? I tried getting this to pass CocoaPods validation but ran into some of those predicate errors: #70 Any tips?

@dzolnai
Copy link

dzolnai commented Oct 12, 2023

@ashfurrow it seems that it doesn't take the deployment target from the spec file. I can reproduce it locally, but have no idea how it could be fixed.

Yes I just need the new Nimble version, because right now our tests do not run on Xcode 15.

@dzolnai
Copy link

dzolnai commented Oct 12, 2023

I think we are running into this issue: CocoaPods/CocoaPods#11839

@ashfurrow
Copy link
Member

Ah fun fun. Okay. So this should work with Xcode 14.2 for now? I can download that and use it to publish the new version.

(Fixing this bug in a PR, as Orta mentioned in that thread, would be a great too. But I want to unblock you all first.)

@mgray88
Copy link
Contributor

mgray88 commented Oct 12, 2023

The only pod spec lint errors I got for #70 were related to Predicate 🤔

edit:
environment:

xcode-select -p
/Applications/Xcode-15.0.0.app/Contents/Developer

swift --version
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-5.9.0.128.108 clang-1500.0.40.1)
Target: x86_64-apple-macosx13.0

pod --version
1.12.1

@dzolnai
Copy link

dzolnai commented Oct 12, 2023

Yes but once you fix those, you will get a hidden DT_TOOLCHAIN error, which then suggests that you upgrade to Pod 1.13.0. And when you do, the same errors will appear (at least, that's what happened to me) as in the top post.

But yes, Predicate needs to be replaced with Matcher in the sources first.

@ashfurrow
Copy link
Member

I've released a new version in #70 for the latest version of Nimble, 6.3.0 of RxNimble. Let me know 👍

@ashfurrow
Copy link
Member

Oh, and Xcode 14.2 did work.

@ashfurrow
Copy link
Member

Thanks to @N1nomiya in #71, I've released 6.3.1 of RxNimble that should fix this. Could someone verify and let us know?

@dzolnai
Copy link

dzolnai commented Oct 18, 2023

Thanks, for us it works as expected now.

I did see the following error when updating:

Specs satisfying the RxNimble (= 6.3.1) dependency were found, but they required a higher minimum deployment target.

I just had to update my first line in the Podfile to:
platform :ios, '13.0'

(We were already using 13.0 as the minimum deployment target for our apps, but that was set in Xcode, not in the Podfile)

@N1nomiya
Copy link
Member Author

Thanks @dzolnai , 6.3.1 works for me in Xcode 15 as well.
I think this issue is ready to close. Thank you all 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants