From b06ea39bc23300e0002f101ebeb128d35641d648 Mon Sep 17 00:00:00 2001 From: Martin Evans Date: Fri, 5 Jul 2024 01:49:51 +0100 Subject: [PATCH] Marked up all failures for `SpecTest_conversions` --- WebAssembly.Tests/Runtime/SpecTests.cs | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/WebAssembly.Tests/Runtime/SpecTests.cs b/WebAssembly.Tests/Runtime/SpecTests.cs index c0371c4..03d505d 100644 --- a/WebAssembly.Tests/Runtime/SpecTests.cs +++ b/WebAssembly.Tests/Runtime/SpecTests.cs @@ -156,7 +156,20 @@ public void SpecTest_const() [TestMethod] public void SpecTest_conversions() { - var skips = new HashSet { 88, 89, 93, 133, 134, 139, 183, 187, 229, 234, 236 }; + var skips = new HashSet + { + 88, // Arithmetic operation resulted in an overflow + 89, // Arithmetic operation resulted in an overflow + 93, // No exception thrown. OverflowException exception was expected + 133, // Arithmetic operation resulted in an overflow + 134, // Arithmetic operation resulted in an overflow + 139, // No exception thrown. OverflowException exception was expected + 183, // Arithmetic operation resulted in an overflow + 187, // No exception thrown. OverflowException exception was expected + 229, // Arithmetic operation resulted in an overflow + 234, // Arithmetic operation resulted in an overflow + 236 // OverflowException exception was expected + }; if (!Environment.Is64BitProcess) // 32-bit JIT operates differently as of .NET Core 3.1. skips.UnionWith([454, 455, 470, 471]); SpecTestRunner.Run(Path.Combine("Runtime", "SpecTestData", "conversions"), "conversions.json", skips.Contains);