From a06f4ebc5bdcf351cc8b931ef9e3d65fe8d0fa0c Mon Sep 17 00:00:00 2001 From: Ryan Hamilton Date: Wed, 6 Mar 2024 20:02:04 +0000 Subject: [PATCH] Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false A number of users have reported issues with oghttp2 including seems wise. Signed-off-by: Ryan Hamilton --- changelogs/current.yaml | 4 ++++ source/common/runtime/runtime_features.cc | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/changelogs/current.yaml b/changelogs/current.yaml index 908a14404ccd..0ac3403d3f0f 100644 --- a/changelogs/current.yaml +++ b/changelogs/current.yaml @@ -11,6 +11,10 @@ behavior_changes: The runtime flag ``envoy.reloadable_features.enable_include_histograms`` is now enabled by default. This causes the ``includeHistogram()`` method on ``Stats::SinkPredicates`` to filter histograms to be flushed to stat sinks. +- area: http2 + change: | + Changes the default value of ``envoy.reloadable_features.http2_use_oghttp2`` to ``false``. This changes the codec used for HTTP/2 + requests and responses. This behavior can be reverted by setting the feature to ``true``. - area: eds change: | Enabling caching caching of EDS assignments when used with ADS by default (introduced in Envoy v1.28). diff --git a/source/common/runtime/runtime_features.cc b/source/common/runtime/runtime_features.cc index f709e7a24984..e2a11b18f348 100644 --- a/source/common/runtime/runtime_features.cc +++ b/source/common/runtime/runtime_features.cc @@ -58,7 +58,7 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_use_balsa_parser); RUNTIME_GUARD(envoy_reloadable_features_http2_decode_metadata_with_quiche); RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header); // Ignore the automated "remove this flag" issue: we should keep this for 1 year. -RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2); +FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2); RUNTIME_GUARD(envoy_reloadable_features_http2_validate_authority_with_quiche); RUNTIME_GUARD(envoy_reloadable_features_http_allow_partial_urls_in_referer); RUNTIME_GUARD(envoy_reloadable_features_http_filter_avoid_reentrant_local_reply);