Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why finger.png the py version psnr decrase so much? #5

Open
oneTaken opened this issue Jul 6, 2020 · 3 comments
Open

why finger.png the py version psnr decrase so much? #5

oneTaken opened this issue Jul 6, 2020 · 3 comments

Comments

@oneTaken
Copy link

oneTaken commented Jul 6, 2020

As described as the title.

sigma = 80:
Py version psnr: 17.781
Cpp version psnr: 20.196

@Ryanshuai
Copy link
Owner

Can you show me the image?
In fact, in some image, the PSNR decrease if sigma is very high. I guess it is because some trick which CPP version took I did not take into the code.

@oneTaken
Copy link
Author

oneTaken commented Jul 6, 2020

Just the case in the README file. the 13-th case.

https://github.com/Ryanshuai/BM3D_py#comparison-of-cpp-version-and-python-version

Maybe some tricks what you explain above is reasonable.

@Ryanshuai
Copy link
Owner

Just the case in the README file. the 13-th case.

https://github.com/Ryanshuai/BM3D_py#comparison-of-cpp-version-and-python-version

Maybe some tricks what you explain above is reasonable.

You could try to fix it and send pull request to me ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants