Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPNameQualifier must match SP Entity ID in strict mode (default strict true) #177

Open
bfjuju opened this issue Jan 7, 2020 · 3 comments

Comments

@bfjuju
Copy link

bfjuju commented Jan 7, 2020

Hi,

SPNameQualifier must match SP Entity ID in strict mode (default strict true). But in real world, SPNameQualifier is not always same than SP entity ID.

Is there a way to add a key/value in sp section in settings like following :

https://github.com/onelogin/python3-saml/blob/6b414775c3617f3711e8959fa849ed564ea6f585/src/onelogin/saml2/response.py#L475

sp_data = self.__settings.get_sp_data()
sp_entity_id = sp_data.get('spNameQualifier', '')
@pitbulk
Copy link
Contributor

pitbulk commented Jan 7, 2020

The SPNameQualifier can be provided with the spnq parameter on the logout method

@bfjuju
Copy link
Author

bfjuju commented Jan 7, 2020

Hi @pitbulk ,

Thanks for your answer but I am talking about SAML SSO process (login).

@pitbulk
Copy link
Contributor

pitbulk commented Jan 15, 2020

Right now there is no way to set SPNameQualifier on the AuthNRequest, if you need that you will need to extend the AuthNRequest class and customize:
https://github.com/onelogin/python3-saml/blob/master/src/onelogin/saml2/authn_request.py#L80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants