OneLogin::RubySaml.format_cert break a cert with comment

[cyc115]

OneLogin::RubySaml.format_cert strips out the BEGIN and END line then remove line breaks. This will break any cert with prefix and suffix comments like the example below:

comment
-----BEGIN CERTIFICATE-----
[...]
-----END CERTIFICATE-----
comment

The formatted certificate will be:

-----BEGIN CERTIFICATE-----
comment
[...]
comment
-----END CERTIFICATE-----

see:
https://github.com/onelogin/ruby-saml/blob/master/lib/onelogin/ruby-saml/utils.rb#L51

[pitbulk]

Why you have comments on the certs? I guess that then those comments should be removed as well by the format_cert method. Do you have a PR?

[cyc115]

I forgot exactly which openssl command I run to generate the pem file but at least with some options openssl will generate cert with the human readable format prefixing the -----BEGIN CERTIFICATE-----.

I don't have a PR but am willing to write one if there's interest in this.

[pitbulk]

Duplicated of #636. Will leave the other one open and close this one.