Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object types do not support ABAP language version keyUser #320

Closed
4 tasks done
schneidermic0 opened this issue Mar 9, 2022 · 6 comments · Fixed by #359
Closed
4 tasks done

Object types do not support ABAP language version keyUser #320

schneidermic0 opened this issue Mar 9, 2022 · 6 comments · Fixed by #359
Assignees
Labels
bug Something isn't working

Comments

@schneidermic0
Copy link
Contributor

schneidermic0 commented Mar 9, 2022

Following object types actually do not support ABAP language version keyUser, but specify this in their enum values:

@larshp
Copy link
Collaborator

larshp commented Apr 21, 2022

again, I'd argue to remove the language version from the object definitions, what if NROB sometime is supported in keyUser? Then the object definition must be changed, but its just another runtime that supports the object

@schneidermic0
Copy link
Contributor Author

I don't think we can remove the ABAP language version as it is stored per object. This design, IMHO, cannot be changed by ABAP file formats. See #44

If new enum values appear in the future, it will be added. We have the same issue for all other enumerations. Currently, we consider this as compatible change.

See: https://github.com/SAP/abap-file-formats/blob/main/docs/json.md#format-versions-and-compatibility

Values for a field (enum) are added (remark: this might lead to syntax errors in ABAP systems which don't support this value)

@larshp
Copy link
Collaborator

larshp commented Apr 21, 2022

the file format does not need to directly reflect the implementation in the system, eg. specific names and/or fields

🎪

@schneidermic0
Copy link
Contributor Author

the file format does not need to directly reflect the implementation in the system, eg. specific names and/or fields

Sorry, I don't understand what you mean

@larshp
Copy link
Collaborator

larshp commented Apr 21, 2022

just going in circles 😁 #44

@schneidermic0
Copy link
Contributor Author

Also fixed with https://launchpad.support.sap.com/#/notes/3138884

This Note has been already linked in abapGit/abapGit#5279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants