Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ABAP CDS Syntax Highlighter for .acds files #372

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Use ABAP CDS Syntax Highlighter for .acds files #372

merged 1 commit into from
Jun 29, 2022

Conversation

BeckerWdf
Copy link
Contributor

With github-linguist/linguist#4614 Github understands "asddls" files and uses
the syntax coloring provided by
https://github.com/FreHu/abap-cds-grammar

Let's use an override for this repo so that acds files just use the
existing coloring for "asddls".
This is explained in:
https://github.com/github/linguist/blob/master/docs/overrides.md

Fixes: #371

With github-linguist/linguist#4614 Github understands "asddls" files and uses
the syntax coloring provided by
https://github.com/FreHu/abap-cds-grammar

Let's use an override for this repo so that acds files just use the
existing coloring for "asddls".
This is explained in:
https://github.com/github/linguist/blob/master/docs/overrides.md

Fixes: #371
@BeckerWdf
Copy link
Contributor Author

@BeckerWdf
Copy link
Contributor Author

BeckerWdf commented Jun 29, 2022

Validation found dead links:

ERROR: 2 dead links found!
[✖] https://api.reuse.software/info/github.com/SAP/abap-file-formats → Status: 0
[✖] https://api.reuse.software/badge/github.com/SAP/abap-file-formats → Status: 0

But that's nothing I have changed.

@larshp
Copy link
Collaborator

larshp commented Jun 29, 2022

I've retriggered the checks, now ok

Copy link
Collaborator

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BeckerWdf BeckerWdf merged commit 7fad0b6 into main Jun 29, 2022
@BeckerWdf BeckerWdf deleted the coloring branch June 29, 2022 13:57
@BeckerWdf
Copy link
Contributor Author

BeckerWdf commented Aug 8, 2022

The result can be seen e.g. in https://github.com/SAP/abap-file-formats/blob/coloring/file-formats/ddls/examples/z_aff_example_ddls.ddls.acds

The coloring is not perfect but we can file PRs on https://github.com/FreHu/abap-cds-grammar

With FreHu/abap-cds-grammar#3 the grammar was improved. As soon as linguist makes a new release and as soon as github consumes this (we don't have control over this). Coloring should improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ABAP CDS Syntax Highlighter for .acds files
2 participants