Skip to content

Commit a725e65

Browse files
committed
add comments
1 parent b663b0b commit a725e65

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pkg/reconciler/reconciler.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,10 @@ func (r *Reconciler) Apply(ctx context.Context, inventory *[]*InventoryItem, obj
389389
// if item was not found, append an empty item
390390
if item == nil {
391391
// TODO: should the owner id check happen always (not only if the object is unknown to the inventory)?
392+
// TODO: since deletion handling now happens late, it can happen that, when an object is moved from its previous compoment into a new one,
393+
// and the previous one gets deleted at the same time, applying the new one runs stuck because of the owner id check;
394+
// so we might add some logic to skip the owner id check in that particular case
395+
392396
// fetch object (if existing)
393397
existingObject, err := r.readObject(ctx, object)
394398
if err != nil {

0 commit comments

Comments
 (0)