[WIP]fix(core, platform): fix illustrated message in table #12689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit 1d06174): https://fundamental-ngx-gh--pr12689-fix-illustrated-msg-hz9edw44.web.app (expires Thu, 07 Nov 2024 15:52:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
droshev
force-pushed
the
fix/illustrated-msg-table
branch
from
fe372e2
to
1d06174
Compare
mikerodonnell89
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Now there's two "no data" examples on the platform table page, and the SVG on this one still doesn't render: https://deploy-preview-12689--fundamental-ngx.netlify.app/#/platform/table/basic#no-data-custom-element
droshev
changed the title
|
looks good, but i checked the e2e test and i don't know if your changes had any effect on something but e2e test is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #12678
Description
fix illustrated messaged in table, add documentation examples in core and platform tables.