BUG - flp-config-sub-generator: FLP config is not writing unique i18n properties

[korotkovao]

Description

When adding flp config to a Fiori application, we are successfully validating that the semantic object and action are a unique combination, otherwise, we ask the user to confirm if they want to overwrite:

However, adding different flp configurations to a Fiori application is using the i18n properties flpTitle and flpSubtitle multiple times in each manifest entry for the flp configuration and the associated i18n.properties file. This means that they would overwrite each other rather than be unique.

Steps to Reproduce

Steps to reproduce the behaviour:

1. Create a Fiori project and add flp configuration
2. Launch the app info page for the Fiori project and add a second flp configuration with a different title and subtitle.

Expected results

The manifest and i18n.properties entries should be unique, perhaps using the semantic object and action as a prefix, e.,g.:

i18n.properties:

manifest.json:

Actual results

Instead, the flpTitle and flpSubtitle are written multiple times to the manifest and i18n.properties file, thereby overwriting each other rather than being unique. See screenshot below:

Screenshots

i18n.properties entries:

Associated manifest.json entries:

Fiori tools component/version

Project Files

OS/Browser/Environment

OS:

• Mac OS
• Windows

Browser:

• Chrome
• Firefox
• Edge

Environment:

• Master
• Staging
• Production

---

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue was missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}