[BUG] Creating btp_subaccount_entitlement does not work for hana-cloud

[Lasseses]

Is there an existing issue for this?

• I have searched the existing issues

What version of the Terraform provider are you using?

1.7.0

What version of the Terraform CLI are you using?

1.9.7

What type of issue are you facing

bug report

Describe the bug

When trying to create a new entitlement for Hana cloud using service_name: hana-cloud and plan_name: hana, it fails with the following report:

More than one plan exists for service name
│ hana-cloud and plan name hana in the same
│ region. Specify the unique identifier of the
│ plan to assign. [Error: 30001/400]

Expected Behavior

Using the BTP CLI the expected behavior can be achieved by also setting the --plan-unique-identifier. When looking at the BTP Terraform Provider tests here, it appears that the readonly attributes id or plan_id seem to could fix this issue in tf.

btp assign accounts/entitlement --for-service hana-cloud --plan hana-cloud-hana --global-account <GAID> --to-subaccount <SAID> --plan-unique-identifier hana-cloud-hana

Steps To Reproduce

resource "btp_subaccount_entitlement" "hana_entitlement" {
subaccount_id =
service_name = "hana-cloud"
plan_name = "hana"
#id = "hana-cloud-hana" --> I have tried but it its readonly
#plan_id = "hana-cloud-hana" --> I have tried but it its readonly
}

User's Role Collections

No response

Add screenshots to help explain your problem

No response

Additional context

I am part of the Cloud Orchestrator team, working on the BTP Crossplane provider. Feel free to reach out to me also internally for further consolidation! Lasse, Friedrich

[lechnerc77]

• Documentation for BTP CLI command: https://help.sap.com/docs/btp/btp-cli-command-reference/btp-assign-accounts-entitlement

• External API for assigning entitlements for subaccounts: https://api.sap.com/api/APIEntitlementsService/path/setServicePlans -> does not support the parameter plan-unique-identifier

• External API for assigning entitlements for directories: https://api.sap.com/api/APIEntitlementsService/path/createOrUpdateEntitlements -> does not support the parameter plan-unique-identifier-> does support the parameter plan-unique-identifier, not available in Terraform resource

[lechnerc77]

Update: Still in process of clarifying the mismatches in the different provisioning flows (API/Terraform vs. BTP CLI)

[lechnerc77]

After internal clarification: the additional optional parameter plan-unique-identifier as available in the BTP CLI (see https://help.sap.com/docs/btp/btp-cli-command-reference/btp-assign-accounts-entitlement) must be added to the resources for entitlements

Tasks:

• Enhance resource btp_suubaccount_entitlement with the new optional parameter plan-unique-identifier
• Enhance the resource btp_directories_entitlement with the nw optional parameter for plan-unique-identifier
• Record a test case for both resources with the additional parameter set
• Enhance the datasources for entitlements with the optional parameter (global account, directory, subaccount)
• Re-record the test cases for the data sources and validate that a value for the parameter is set