Skip to content

Commit 345d8f5

Browse files
committed
npm translator: Fix code style and add comments
1 parent d8c2354 commit 345d8f5

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

lib/translators/npm.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,16 +295,16 @@ class NpmTranslator {
295295
// As of today, collections only exist in shims
296296
this.shimCollection(pkg.name, pkg);
297297
if (pkg.collection) {
298-
log.verbose(
299-
"Unable to locate module %s via resolve logic, but found a collection in parent hierarchy: %s",
300-
moduleName, pkg.name);
298+
log.verbose(`Unable to locate module ${moduleName} via resolve logic, but found ` +
299+
`a collection in parent hierarchy: ${pkg.name}`);
301300
const modules = pkg.collection.modules || {};
302301
if (modules[moduleName]) {
303302
const modulePath = path.join(path.dirname(result.path), modules[moduleName]);
304-
log.verbose("Found module %s in that collection", moduleName);
303+
log.verbose(`Found module ${moduleName} in that collection`);
305304
return modulePath;
306305
}
307-
throw new Error(`[npm translator] Could not find module ${moduleName} in collection ${pkg.name}`);
306+
throw new Error(
307+
`[npm translator] Could not find module ${moduleName} in collection ${pkg.name}`);
308308
}
309309
}
310310

@@ -320,11 +320,13 @@ class NpmTranslator {
320320
registerPendingDependencies({dependencies, parentProject, parentPath}) {
321321
Object.keys(dependencies).forEach((moduleName) => {
322322
if (this.pendingDeps[moduleName]) {
323+
// Register additional potential parent for pending dependency
323324
this.pendingDeps[moduleName].parents.push({
324325
project: parentProject,
325326
path: parentPath
326327
});
327328
} else {
329+
// Add new pending dependency
328330
this.pendingDeps[moduleName] = {
329331
parents: [{
330332
project: parentProject,

0 commit comments

Comments
 (0)