Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table]: TableSelection select all checkbox value is wrongly set when filtering data #10658

Open
1 task done
rvsia opened this issue Jan 24, 2025 · 5 comments
Open
1 task done
Labels
bug This issue is a bug in the code for discussion

Comments

@rvsia
Copy link

rvsia commented Jan 24, 2025

Bug Description

When filtering data in table and using select all checkbox to select all data, it's value status (checked/unchecked) gets unsynchronized with the data and it leads to un-expected behavior

Affected Component

ui5 table

Expected Behaviour

Select all checkbox is checked only if all data in the table are selected

Ideally it would great if the table selection would be controlled so we can manually set its value

Isolated Example

n/a

Steps to Reproduce

  1. Filter data in table
  2. Select all
  3. Un-filter data
  4. Select all checkbox is still checked

Log Output, Stack Trace or Screenshots

Image

Priority

Medium

UI5 Web Components Version

Latest

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Organization

SAP Signavio

Declaration

  • I’m not disclosing any internal or sensitive information.
@rvsia rvsia added the bug This issue is a bug in the code label Jan 24, 2025
@didip1000 didip1000 self-assigned this Jan 24, 2025
@didip1000
Copy link
Contributor

Hey @rvsia,

Can you please provide an isolated example replicating the issue? You can edit one of our existing samples, or create one on https://stackblitz.com/.

Thank you,
Diana

@rvsia
Copy link
Author

rvsia commented Jan 24, 2025

@didip1000 Can I provide a React example?

@didip1000
Copy link
Contributor

Hey @rvsia,

If you can provide an example without react that would be preferable because we need to make sure the issue is with the components themselves not the react wrapper.

Thanks,
Diana

@nnaydenow
Copy link
Contributor

Hi,

The behavior of the table seems to require clarification before confirming it as a bug.

What should happen if the "Select All" checkbox is clicked, and new items are added to the table? As I see it, the app currently has no way to understand that the checkbox was previously clicked in order to update its state accordingly.

@aborjinik what’s your opinion? Should we provide an event developers, allowing developers to align their model with the current component state? Or should we automatically uncheck the "Select All" checkbox when a new, unselected row is added to the table?

@Ankitadoshi
Copy link

Ankitadoshi commented Feb 5, 2025

Hi Team,

We are also facing the same issue in our SF project while filtering the table with multi select option
This is a high priority issue for us as our monthly release is impacted by this

Thanks,
Ankita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code for discussion
Projects
Development

No branches or pull requests

4 participants