Skip to content

[SF][Table]: [Single Selection style in Table is not consistant with fiori guideline] #10893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
tandan0813 opened this issue Feb 19, 2025 · 5 comments · Fixed by #11520
Closed
1 task done

Comments

@tandan0813
Copy link

Describe the bug

Since we upgraded to the new table, the Single Selection mode's style is changed, and we don't want the radio button.

Fiori Guideline:
Image

Table(experimental):
Image

Legacy Table
Image

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v2/?path=/story/data-display-table--with-selection

Reproduction steps

No response

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

2.7.2

UI5 Web Components Version

2.7.2

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi Colleagues, this issue also mentions the difference of the single section mode, but since it's only in the comments, I'm not sure if you want to treat this one as duplicate.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Feb 19, 2025
@Todor-ads Todor-ads self-assigned this Feb 19, 2025
@Todor-ads
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-core ,

could you please check this issue?

Thanks,
Todor

@aborjinik aborjinik moved this from New to Planned in Planning - Topic TBL Feb 23, 2025
@aborjinik aborjinik moved this from Planned to Rejected in Planning - Topic TBL Feb 23, 2025
@aborjinik aborjinik moved this from Rejected to Planned in Planning - Topic TBL Feb 24, 2025
@aborjinik aborjinik reopened this Feb 24, 2025
@simlin simlin moved this from Planned to In progress in Planning - Topic TBL May 9, 2025
aborjinik added a commit that referenced this issue May 14, 2025
- RowSelector: In this default mode, rows can only be selected using the row selector column.
- RowOnly: Rows can only be selected by clicking directly on the row, as the row selector column
  is hidden.

Fixes: #10893
aborjinik added a commit that referenced this issue May 14, 2025
- RowSelector: In this default mode, rows can only be selected using the row selector column.
- RowOnly: Rows can only be selected by clicking directly on the row, as the row selector column
  is hidden.

Fixes: #10893
aborjinik added a commit that referenced this issue May 14, 2025
- RowSelector: In this default mode, rows can only be selected using the row selector column.
- RowOnly: Rows can only be selected by clicking directly on the row, as the row selector column
  is hidden.

Fixes: #10893
aborjinik added a commit that referenced this issue May 14, 2025
- RowSelector: In this default mode, rows can only be selected using the row selector column.
- RowOnly: Rows can only be selected by clicking directly on the row, as the row selector column
  is hidden.

Fixes: #10893
aborjinik added a commit that referenced this issue May 15, 2025
- RowSelector: In this default mode, rows can only be selected using the row selector column.
- RowOnly: Rows can only be selected by clicking directly on the row, as the row selector column
  is hidden.

Fixes: #10893
aborjinik added a commit that referenced this issue May 21, 2025
- RowSelector: In this default mode, rows can only be selected using the row selector column.
- RowOnly: Rows can only be selected by clicking directly on the row, as the row selector column
  is hidden.

Fixes: #10893
aborjinik added a commit that referenced this issue May 21, 2025
- RowSelector: In this default mode, rows can only be selected using the row selector column.
- RowOnly: Rows can only be selected by clicking directly on the row, as the row selector column
  is hidden.
- Documentation fixes

Fixes: #10893
Copy link

This issue has been closed. To reopen, just leave a comment!

1 similar comment
Copy link

This issue has been closed. To reopen, just leave a comment!

@simlin simlin moved this from In progress to Done in Planning - Topic TBL May 28, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.11.0-rc.3 🎉

The release is available on v2.11.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

6 participants