Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate NumberInput Component #4353

Open
texttechne opened this issue Nov 17, 2021 · 5 comments
Open

Separate NumberInput Component #4353

texttechne opened this issue Nov 17, 2021 · 5 comments

Comments

@texttechne
Copy link

Feature Request Description

Several issues regarding the input type=number component have come up:

Since numbers do play an important role in any SAP system, this component should work reliably.

However, right now there is even documentation lacking => there's no way to try out / play around with such a component in your documentation. It's completely subsumed under the input component.

All of this leads me to the consideration that it could be worthwhile to create an own number component, which would also solve the issue of different attributes which are valid for any text input vs number input

  • maxLength vs min/max
  • step
  • ...

Proposed Solution

Make an own component for number inputs!

Proposed Alternatives

Extend the documentation to have an example of an input type=number, so that people can try it out.

@texttechne
Copy link
Author

@ilhan007 I think this is a suggestion tailored to your role, but I'm just guessing here...

@hristop
Copy link
Contributor

hristop commented Sep 8, 2023

Internal BLI was created: FIORITECHP1-28567

@hristop
Copy link
Contributor

hristop commented Sep 11, 2023

There are currently few issues / feature requests regarding this topic and we have decided to gather them here and continue in this thread as the main one.

In general, the topic is complex and we will need focused effort to proceed with it, which we currently do not have.
As already mentioned above, there is currently internal backlog item, which will be considered when forming the priorities we will work on.

Besides the above mentioned issues there are several more related to such numeric input:

@texttechne
Copy link
Author

Hi @hristop,

I went down that road some time back and I can only agree with your assessment: I've never created a more complex user interface, so it really requires focused effort...

Maybe you're interested in the outcome / behaviour: Here you find a storybook for our version of a NumberInput. And then we also created a CurrencyInput as well for convenience.

Source code is available, but it's built on top of React, so I don't know how helpful that is....

@hristop
Copy link
Contributor

hristop commented Sep 15, 2023

Hi @texttechne ,

Thank you for providing this! It will be helpful in some way for sure.

Best Regards,
Hristo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Approved
Development

No branches or pull requests

6 participants