Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floats not supported in Omega_h adapter #134

Open
philip-davis opened this issue Jul 8, 2023 · 0 comments
Open

Floats not supported in Omega_h adapter #134

philip-davis opened this issue Jul 8, 2023 · 0 comments

Comments

@philip-davis
Copy link
Collaborator

philip-davis commented Jul 8, 2023

std::variant<OmegaHField<Omega_h::I8, InternalCoordinateElement>,

The XGC adapter supports single-precision floats, but the Omega_h adapter does not. Attempts to use floats with the Omega_h adapter result in fairly difficult to interpret error messages when doing AddField (at least in gcc). This isn't a bug, but the asymmetry does generate some amount of surprise. There is no single-precision Omega_H type, which is presumably why the Omega_h adapter does not support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant