-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong information for some particles after CabM particle structures rebuild operation #119
Comments
With
|
Yes, I see similar issues, the information associated with the particles gets changed and particles are no longer in the element. |
I tried to reproduce this on my local machine, but was unable to get a failure. Can either of you send a simplified example that produces the erroneous particle data after rebuild, so I can better investigate the issue? |
Hi Gerrett @diamog: thank you for looking into this.
|
@diamog: I made a smaller XGCm test case with 1000 mesh elements that can reproduce the error on Summit:
Looking at this error closer, it corresponds to this code segment, https://github.com/SCOREC/xgcm/blob/1a0ad1e80a4cb099c3fd6b31ab10a1c835aebc4c/src/xgcm_particle.hpp#L329-L344:
This suggests that Please let me know if this case is still be too large for your test. |
While developing on a new particle code,
Comet
, I encountered the following issue:CabM
particle structure, when the number of particles per GPU is>~50 million
, information for some particles are incorrect after particle structure rebuild.SCS
particle structure, everything works fine.XGCm
issue when64 million
particles per GPU was used in that case: https://github.com/SCOREC/xgcm/issues/163.Steps to reproduce the issue:
pumi-pic/particle_structs/test/test_rebuild.cpp
Lines 138 to 163 in 7b55b1b
0<=x<=1, 0<=y<=1
.Similarly, if no new particles are being added:
particle search
will mark particles (which are no longer in the simulation domain) for deletion.CabM
particle structure.The text was updated successfully, but these errors were encountered: