Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing for the rest of blob commands - part 1 #197

Closed
7 tasks
iricigor opened this issue Oct 8, 2020 · 2 comments · Fixed by #211
Closed
7 tasks

Unit testing for the rest of blob commands - part 1 #197

iricigor opened this issue Oct 8, 2020 · 2 comments · Fixed by #211
Assignees
Labels
testing Testing needs to be implemented or fixed
Milestone

Comments

@iricigor
Copy link
Contributor

iricigor commented Oct 8, 2020

This continues work from #196

We will do it in two steps:

Simple tests implementation should contain for each of the three classes

  • add new private property and constructors to real classes and replace it in the code
  • add shared arguments and real arguments tests
  • add generic method execute tests, at least with failures

Complex tests should contain this work for all three classes:

  • generic method execute with success tests
  • real method execute tests

Watch it for FileSystem changes. Some methods are creating new files / directories which should be avoided.

@iricigor iricigor self-assigned this Oct 8, 2020
@iricigor iricigor added the testing Testing needs to be implemented or fixed label Oct 8, 2020
@iricigor iricigor added this to the v0.6 milestone Oct 8, 2020
@iricigor
Copy link
Contributor Author

Starting to add tests for these three commands:

  • - ListBlobs
  • - GetBlobs
  • - SetBlobs

Just for a record, overall code coverage in azmi-main was 39% at the start of this task (255 block covered vs 396 not covered).
Total number of tests was 73 in azmi-main and additional 27 in azmi-commandline

@iricigor
Copy link
Contributor Author

iricigor commented Oct 17, 2020

List of issues that should be solved later:

  • add test for absolute-paths in GetBlobs-Tests.cs
  • SetBlob test depends on FileSystem commented out

P.S. This list will be updated during work and issues will be created after PR is reviewed.

@iricigor iricigor changed the title Unit testing for the rest of blob commands Unit testing for the rest of blob commands - part 1 Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing needs to be implemented or fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant