New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid style fixes #227

Open

4 of 7 tasks

coreyhunt opened this issue May 2, 2022 · 1 comment

Assignees

coreyhunt commented May 2, 2022 •

edited by shawnbot

Loading

The data grid has various style issues that have appeared over time and needs to be updated.

Table needs to be full width to allow for more content to be displayed
Field heights are not equal
"Remove" button icon is not vertically centered
Dropdown list items are line-breaking too quickly
Dropdown with a selection obfuscates the delete and dropdown icons
Add button icon needs right-margin

Proposed changes

Add w-full to table line 1
Decide padding as rem or px for all inputs
Remove v-align-top to tr on line 38
Align the icons and fix spacing for the buttons (X and Add Another)
Remove padding-right: 100px for the selections
Fix word break in the select dropdown
Make sure the selections do not overlay the Close icon

coreyhunt assigned shawnbot and JimBrodbeck

Contributor

nlsfds commented May 2, 2022

We also need to add text-left and v-align-baseline to th for mobile view.

shawnbot mentioned this issue

Fix up datagrid layout #228

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment