Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build job with SFML_ENABLE_PCH=1 #41

Open
vittorioromeo opened this issue Apr 4, 2023 · 3 comments
Open

Add build job with SFML_ENABLE_PCH=1 #41

vittorioromeo opened this issue Apr 4, 2023 · 3 comments

Comments

@vittorioromeo
Copy link
Member

Useful to catch regressions with PCH support enabled.

@eXpl0it3r
Copy link
Member

I guess the question is, whether we should expand the buildbot matrix or expand the GitHub Actions matrix.

What do you think, @ChrisThrasher?

@ChrisThrasher
Copy link
Member

I'd rather do more work in GitHub Actions since it's tied to version control. I'd prefer if the Buildbot was reserved for things that are unfeasible in GitHub Actions like building on FreeBSD or with MinGW.

@binary1248
Copy link
Member

As @ChrisThrasher said, buildbot is preferred when we are building for exotic configurations. If something can be tested on the VMs that actions provides it should be preferred instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants