Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated code in book sources to remove warnings #8

Open
scottfurry opened this issue May 1, 2018 · 3 comments
Open

Update deprecated code in book sources to remove warnings #8

scottfurry opened this issue May 1, 2018 · 3 comments

Comments

@scottfurry
Copy link

Building book examples against SFML latest (2.4.2) results in a few deprecation warnings. These warnings can be broken down into two cases:

Diff at pastebin updates code base to remove warnings during compile.

@Bromeon
Copy link
Member

Bromeon commented Jun 23, 2019

Thanks for the report. Upgrading deprecated methods is always a trade-off: on one hand we remove the warnings, but on the other we break compatibility with older SFML 2.x versions. Since the book claims to be compatible with SFML 2.0, while later 2.x versions will always be backwards-compatible, it might be better to ensure maximum compatibility.

However it seems like CMake finding SFML (2.5+) should also be updated, such a change could then come with a general overhaul (+fixing several compiler warnings meanwhile appearing).

@nickphilomath
Copy link

nickphilomath commented Nov 16, 2023

i cannot compine 9 and 10. others seem working fine
i am using linux and makefile to build

image

image

@eXpl0it3r
Copy link
Member

Make sure FLAC dev libs are installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants