Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use major and minor version in the CSFML library names #247

Closed
wants to merge 1 commit into from

Conversation

eXpl0it3r
Copy link
Member

@eXpl0it3r eXpl0it3r commented May 18, 2024

This solves two issues:

@eXpl0it3r eXpl0it3r added the Feature New functionality or extending of an existing one label May 18, 2024
@eXpl0it3r
Copy link
Member Author

A limitation is, that it won't find default CSFML library names anymore, meaning on Linux you'd get libsfml-graphics.so.2.6, but now SFML.Net is looking for libsfml-graphics.2.6.so, nor for Windows where it's csfml-graphics.dll, it now needs to be csfml-graphics.2.6.dll.

I wonder if it's worth doing this hardcoding, or if we should just ship the ones needed. That would libsfml-*.so, libsfml-*.so.2.6, libsfml-*.dylib, and libsfml-*.2.6.dylib

@eXpl0it3r
Copy link
Member Author

After the conclusions in #226, we won't go with this change.

@eXpl0it3r eXpl0it3r closed this May 18, 2024
@eXpl0it3r eXpl0it3r deleted the feature/library-name branch September 5, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality or extending of an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant