Use same syntax for updating uniform inputs and uniform buffer inputs #1683
Labels
area: renderer
Concerns our graphics renderer
code quality
Does not alter behavior, but beauty of our code
good first issue
Suitable for newcomers
hacktoberfest
For newcomers from Hacktoberfest event
improvement
Enhancement of an existing component
just do it
You can start working on this, there should be nothing left to discuss
lang: c++
Done in C++ code
opengl
Required Skills: C++, maybe OpenGL
Difficulty: Easy
In #1664 we switched the structure of OpenGL uniform inputs (
GlUniformInput
) to more performance friendly code. Uniform buffer inputs (GlUniformBufferInput
) were not changed in the PR as the performance gain would have been only marginal. However, it would make sense for code quality purposes to keep the update syntax of both input types roughly the same, so that they can be maintained in the same way.The tasks mostly consist of porting the changes from #1664 to the flow used for updating the uniform buffers. A simple example for uniform buffers that can be used for testing purposes is available in renderer demo 5 which you can access by running this command:
Tasks:
GlUniformInput
made in Vectorize uniform inputs #1664 to theGlUniformBufferInput
classFurther Reading
The text was updated successfully, but these errors were encountered: