You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we are adding the running command back to pending list unconditionally. This may not be desirable in some cases, e.g. when the termination triggers checkpointing which can potentially fail and in this scenario it's better to put the command into the finished list specifying the returned error code.
A snippet to illustrate the idea:
ifsigterm_handler.procisnotNone:
error_code=sigterm_handler.proc.wait()
ifsigterm_handler.commandisnotNone:
iferror_code==0: # The command was terminated successfully.command_manager.set_running_command_as_pending(sigterm_handler.command)
else:
command_manager.set_running_command_as_finished(sigterm_handler.command, error_code)
Right now we are adding the running command back to
pending
list unconditionally. This may not be desirable in some cases, e.g. when the termination triggers checkpointing which can potentially fail and in this scenario it's better to put the command into thefinished
list specifying the returned error code.A snippet to illustrate the idea:
Relevant code:
smartdispatch/workers/base_worker.py:54
The text was updated successfully, but these errors were encountered: