Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a better WeightInitializer class to easily initialize weights of a model #14

Closed
MarcCote opened this issue Aug 6, 2015 · 3 comments
Closed

Create a better WeightInitializer class to easily initialize weights of a model #14

MarcCote opened this issue Aug 6, 2015 · 3 comments
Assignees
@ASalvail

Comments

@MarcCote
Copy link
Member

MarcCote commented Aug 6, 2015

I think we should be more Object Oriented than what we already have i.e. only one WeightInitializer class with multiple types of initialization method. There is probably a design pattern to that the right way.
@MarcCote MarcCote mentioned this issue Aug 6, 2015
Closed
@MarcCote
Copy link
Member Author

MarcCote commented Aug 6, 2015

According to Issue #13, we should put the WeightInitializer class in the smart-learner library.

@ASalvail ASalvail self-assigned this Aug 6, 2015
@ASalvail
Copy link
Member

ASalvail commented Aug 6, 2015

Will do something, probably before the end of the day. Will deprecate the initializer in smart-models.

@ASalvail
Copy link
Member

ASalvail commented Aug 6, 2015

See PR #17 and PR #24 from smartpy.

@ASalvail ASalvail closed this as completed Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ASalvail ASalvail

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarcCote @ASalvail