Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal part of relativeFilArchiveURI in Image extrcation [Zsolt] #198

Open
RoyMudie opened this issue Nov 23, 2021 · 0 comments
Open

Comments

@RoyMudie
Copy link
Contributor

The field contains the full path to the referenced image file in HICs internal file system.
Part of the path could be useful for the researcher for linking the record to the image in the extraction folder, but the root part is not relevant.
Could you please change the plugin to return the path relative to the extraction folder?

Chris Hall added a comment - 15/Feb/21 9:46 AM
[~tznind] / [~ltramma] - this seems silimar to the US2.ai issue, perhaps it's not. Can both be fixed at the same time?
Thomas Nind added a comment - 15/Feb/21 9:54 AM
This is entirely unrelated to US2.ai which doesn't even use the imaging functionality of RDMP at all.

The FoDicomAnonymiser may end up getting replaced with something else once the full 'mirroring' architecture is in place (the extraction plugin isn't used in Edinburgh).

Currently the input folder is replaced with the output path on your server. We could probably express that relative to a root path e.g. the extraction root if desired (we would just add another boolean option to the component to express it thus):

https://github.com/HicServices/RdmpDicom/blob/master/Rdmp.Dicom/Extraction/FoDicomBased/FoDicomAnonymiser.cs#L157

https://jira.hic.dundee.ac.uk/browse/RDMPSUP-126

@tznind tznind transferred this issue from HicServices/RDMP Nov 24, 2021
@tznind tznind changed the title Remove internal part of relativeFilArchiveURI in Image extrcation Remove internal part of relativeFilArchiveURI in Image extrcation [Zsolt] Aug 26, 2022
@tznind tznind moved this to Todo in HIC Mirror Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants