Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for AutoRoutingAttacher #338

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Mar 17, 2023

Add unit testing for AutoRoutingAttacher

@jas88 jas88 requested a review from darshad-github March 17, 2023 21:34
Comment on lines +65 to +72
foreach(var tag in Tags)
{
var adder = new TagColumnAdder(tag,TagColumnAdder.GetDataTypeForTag(tag,tt),tableInfo as TableInfo ?? throw new Exception("Got non-TableInfo from DoImport"),new ThrowImmediatelyCheckNotifier())
{
SkipChecksAndSynchronization = true
};
adder.Execute();
}

Check notice

Code scanning / CodeQL

Missed opportunity to use Select

This foreach loop immediately [maps its iteration variable to another variable](1) - consider mapping the sequence explicitly using '.Select(...)'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants