Skip to content

Releases: SMI/SmiServices

v5.2.0

10 Aug 14:43
224ec42
Compare
Choose a tag to compare

Feature

  • #1254 by tznind. Change
    "Setup" to a library and make it runnable from smi as verb
  • #1255 by tznind. Add support for running RDMP with YamlRepository backend

Bugfix

  • #1241 by rkm. Refactor IsIdentifiableQueueConsumer
    • Improve exception handling to better handle errors caused by IClassifier
    • Remove redundant fileSystemRoot from constructor
    • Add tests
  • #1256 by rkm. Ensure MongoDB service started in Windows CI. Caused by actions/runner-images#5949.

Removal

  • #1251 by rkm. Remove remaining IsIdentifiable code and CI config

What's Changed

Full Changelog: v5.1.3...v5.2.0

v5.1.3

21 Jul 16:07
dee501b
Compare
Choose a tag to compare
  • #1229 by dependabot. Bump IsIdentifiable from 0.0.4 to 0.0.5 to fix broken API

What's Changed

Full Changelog: v5.1.2...v5.1.3

v5.1.2

18 Jul 20:36
9ad161b
Compare
Choose a tag to compare

Bugfix

  • #1223 by rkm. Fix setup.py in Smi_Common_Python to include all files, regardless of the current directory.

What's Changed

Full Changelog: v5.1.1...v5.1.2

v5.1.1

18 Jul 12:06
0fb763a
Compare
Choose a tag to compare

Bugfix

  • #1216 by jas88. Bugfix: issue #1217, microservices prematurely exiting since RabbitMQ no longer delays completion

What's Changed

  • Bump HIC.RDMP.Plugin.Test from 7.0.13 to 7.0.14 by @dependabot in #1205
  • Bump HIC.RDMP.Plugin from 7.0.13 to 7.0.14 by @dependabot in #1206
  • Bump StackExchange.Redis from 2.6.45 to 2.6.48 by @dependabot in #1208
  • Bump maven-assembly-plugin from 3.3.0 to 3.4.0 in /src/common/com.smi.microservices.parent by @dependabot in #1209
  • Bump System.IO.Abstractions.TestingHelpers from 17.0.18 to 17.0.21 by @dependabot in #1210
  • Bump commons-configuration2 from 2.7 to 2.8.0 in /src/common/com.smi.microservices.parent by @dependabot in #1212
  • Bump System.IO.Abstractions from 17.0.18 to 17.0.21 by @dependabot in #1211
  • Bump maven-assembly-plugin from 3.4.0 to 3.4.1 in /src/common/com.smi.microservices.parent by @dependabot in #1213
  • Bump CsvHelper from 27.2.1 to 28.0.0 by @dependabot in #1214
  • Bump actions/setup-java from 3.4.0 to 3.4.1 by @dependabot in #1215
  • Add wait loop for all Rabbit work to finish before quitting by @jas88 in #1216
  • Bump CsvHelper from 28.0.0 to 28.0.1 by @dependabot in #1218
  • Bump System.IO.Abstractions.TestingHelpers from 17.0.21 to 17.0.23 by @dependabot in #1220
  • Bump System.IO.Abstractions from 17.0.21 to 17.0.23 by @dependabot in #1221
  • Release/v5.1.1 by @rkm in #1222

Full Changelog: v5.1.0...v5.1.1

v5.1.0

23 Jun 16:14
9bd842f
Compare
Choose a tag to compare

Feature

  • #1074 by rkm. Switch CI to GitHub Actions
  • #1134 by jas88. Remove DeadLetterReprocessor and associated code, more elegant native RabbitMQ approach available if needed.
  • #1190 by howff. Anonymise names and dates in SRs, just in case (useful for demo). Proceed without ID mapping if DB unavailable (useful for testing).
  • #1199 by tznind. Added Setup utility for checking config settings (connection strings, queue setup etc)
  • #1200 by jas88. Add new DicomLoader CLI application for batch-loading DICOM files and archives

Bugfix

  • #1087 by rkm. [CI] Misc. CI fixes
    • Fixes the build scripts to respect any intermediate non-zero return codes
    • Fixes the build scripts to only build linux-x64 and win-x64
    • Fixes the build scripts to select the correct build configuration
    • Removes a bogus test leftover from #1089
    • Temporarily disables a few tests requiring a fix for the leptonica libs
  • #1088 by rkm. Use DirectConnection instead of obsolete ConnectionMode. Fixes #990
  • #1089 by rkm. Remove invalid extraction modality check. Fixes #1059
  • #1128 by jas88. Update RabbitMQ Nuget package and associated API calls
  • #1138 by jas88. Use Chocolatey to install SQL 2019 LocalDB instead of Powershell script
  • #929 by howff. Structured Reports improvements from PR#929
    • Updated documentation
    • Simplify SRAnonTool using external program semehr_anon.py
    • Handle ConceptNameCodeSequence which has VR but no Value
    • Ensure 'replaced' flag is not reset
    • Write replacement DICOM whichever content tag is found
    • Extract metadata from Mongo to go alongside anonymised text
    • Redact numeric DICOM tags with all '9' not all 'X'
    • Allow badly-formatted text content which contains HTML but does not escape non-HTML symbols

Change

  • #1023 by jas88. RabbitMQ tidyup
    • Fix both C# and Java server version check logic
    • Reuse Connection more per RabbitMQ guidance
    • Tidy up some Java exception handling logic

Meta

  • #1082 by rkm. CI: Don't exit early if a single test project has failures

What's Changed

Read more

v5.0.1

18 Feb 10:50
f163100
Compare
Choose a tag to compare

Bugfix

  • #1054 by rkm. Swap stderr reading and process.waitFor in SmiCtpProcessor to avoid a deadlock

v5.0.0

17 Feb 17:58
Compare
Choose a tag to compare

Feature

  • #1040 by tznind. Updated to latest dotnet sdk (net6)
  • #973 by rkm. Adds the basis for a new "DicomAnonymiser" microservice, which can be used in place of the existing Java CTP service. It supports pluggable anonymisers through the
    IDicomAnonymiser interface. No implementations are provided in this PR.

Bugfix

  • #1010 by rkm. Update CI script to pull tessdata file from the new branch name (main not master)
  • #1050 by rkm. Disable coverage upload which is currently broken for .NET 6
  • #1052 by rkm. Ensure any errors encountered when running SRAnonTool are handled properly and produce an appropriate status message.
  • #885 by howff. Always convert PHI to XML regardless of annotation_mode setting.
  • #914 by rkm. Fix #913; error if file extraction command is re-run after being cancelled
  • #915 by rkm. Fix #891; jobId not created until extraction is completed.
  • #917 by rkm. Ensure control exchange exists for ExtractImagesHostTests
  • #926 by rkm. Fixes the current CI issues by restricting the creation of the ControlExchange to the RequiresRabbit test decorator.
  • #931 by rkm. Ensure the python version used in CI runs is exactly what we specify
  • #968 by rkm. Remove reference to System.Drawing.Common
  • #976 by jas88. Fix issue
    #921 - erroneous stripping of root path to empty string in GlobalOptions
  • #981 by rkm. Fix deprecated python collections import for py310+
  • #987 by rkm. Treat all build warnings as errors, and fix or disable existing ones. Also remove unused System.Security.AccessControl package.

Meta

  • #923 by rkm. Allow newer minor SDK versions to build the sln. global.json specifies the minimum version which will be used in the CI.
  • #986 by rkm. Add missing reference to NLog.

v4.0.0

09 Aug 15:31
97314cc
Compare
Choose a tag to compare

Feature

  • #849 by jas88. CTPAnonymiser refactoring
    • Reduce memory footprint (issue #837)
    • Simplify RabbitMQ message handling
    • Stop creating temporary copy of input file - no longer needed in EPCC environment without Lustre FS (per issue #836)
    • Add checks input file is readable not just extant, hopefully fixing issue #533
  • #861 by rkm. Add Equ to automatically implement equality members for classes.
  • #878 by rkm. Update RDMP packages with replacement of System.Data.SqlClient with Microsoft.Data.SqlClient. Replace usages of same in codebase

Bugfix

  • #764 by howff. Clean up the Python code lint after running pylint3
  • #841 by tznind. Fixed bug when disposing CsvDestination instances that have not begun writing any output
  • #880 by tznind. Fixed edge case in IdentifierMapper when a dicom tag has illegal multiplicity in PatientID field

Meta

  • #843 by rkm. Add pre-commit and codespell. Fix all current spelling mistakes
  • #844 by rkm. Fixup regex in codespell config
  • #855 by rkm. Specify dotnet SDK version in global.json
  • #859 by rkm. Bump LangVersion to 9.0
  • #876 by rkm. Add check and error message for missing coveralls token
  • #877 by rkm. Fix setting replication for MongoDB in Windows CI pipelines

Removal

  • #848 by rkm. Removed NationalPACSAccessionNumber from all metadata

v3.2.1

07 Jul 10:58
abef4ab
Compare
Choose a tag to compare

Bugfix

  • #834 by tznind. Improved logging and fixed yaml options not being respected in IsIdentifiableReviewer

v3.2.0

05 Jul 12:54
663a0a3
Compare
Choose a tag to compare

Feature

  • #795 by tznind. Added support for specifying IsIdentifiable CLI options in the yaml config files instead of command line (command line will always take precedence if both are specified)
  • #797 by tznind. Added custom themes to IsIdentifiableReviewer. Use flag --theme mytheme.yaml
  • #801 by tznind. Added help and cancel buttons to custom pattern dialog in reviewer
  • #802 by tznind. Added IsIdentifiableReviewer settings into main yaml config
  • #818 by tznind. Added Rules Manager to IsIdentifiable Reviewer

Bugfix

  • #787 by rkm. Fix the call to the release changelog script
  • #788 by rkm. Require all CI tests to pass before packaging runs
  • #789 by rkm. Don't upload coverage for tagged builds
  • #796 by tznind. Fixed bug opening corrupted reports in IsIdentifiableReviewer crashing the application
  • #806 by tznind. Replace use of GlobalColorScheme with the proper static members in Terminal.Gui that will propagate correctly for all windows without having to set them manually.
  • #811 by rkm. Fix coverage task always running even if a previous task failed

Doc

  • #823 by tznind. Refresh documentation for IsIdentifiableReviewer