Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and document BEM coefficient normalization #48

Open
ryancoe opened this issue Mar 12, 2020 · 4 comments
Open

Review and document BEM coefficient normalization #48

ryancoe opened this issue Mar 12, 2020 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested
Milestone

Comments

@ryancoe
Copy link
Member

ryancoe commented Mar 12, 2020

Carrying this from #36... we need to review how/where (i.e., in what functions) we are normalizing and de-normalizing the BEM coefficients. If our approach is logical, leave as is and document. If not logical, update.

@ryancoe ryancoe added documentation Improvements or additions to documentation question Further information is requested labels Mar 12, 2020
@ryancoe
Copy link
Member Author

ryancoe commented Mar 12, 2020

I believe, this currently works as follows:

  1. Somewhere (not sure exactly where...), the BEM coefficients are normalized
  2. For every design in a study, the de-normalization is performed in RM3_getPow.m - this certainly doesn't seem logical to me

@ssolson
Copy link
Collaborator

ssolson commented Mar 12, 2020

@ryancoe making RM3_getPow.m this more logical is under development in #45. What line are you referring to for the normalization?

@ryancoe
Copy link
Member Author

ryancoe commented Mar 26, 2020

It appears that

I don't understand the rest of the structure/flow well enough to say if this is the most logical way to do it or not.

@H0R5E H0R5E added this to the 0.2 milestone Apr 17, 2020
@H0R5E H0R5E modified the milestones: 0.2, 0.3 Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants