You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I sent a std::numeric_limits<long long>::max() in a table created with the ddl, type dt_long_long (value 9223372036854775807), in the database, the value is -9223372036854775808.
The text was updated successfully, but these errors were encountered:
Sildra
changed the title
Oracle doesn't support std::numeric_limits<long long>::max() in number
Oracle incorrect DDL handling
Oct 13, 2023
Using binary_double for double columns looks like a good idea (as an aside, we should drop get_double_sql_type() and just use SQLT_BDOUBLE, it seems useless to keep compatibility with Oracle 9.x and earlier which is surely not used any more?) and so does using the correct precision for number, so please don't hesitate to make a PR with your changes.
If I could wish for something here, it would be to make the test code simpler to understand as it's really difficult to follow. Generally speaking, the more straightforward the testing code is, easier it is to fix any problems when it breaks, so it would be nice to keep it as simple as possible even at the price of making it less generic/complete.
I sent a
std::numeric_limits<long long>::max()
in a table created with the ddl, type dt_long_long (value 9223372036854775807), in the database, the value is -9223372036854775808.The text was updated successfully, but these errors were encountered: